chore: split VE script up #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing splitting AgSpaceStuff into AgSpaceStuff and AgShipShake
EmosewaMC
previously approved these changes
May 26, 2024
Co-authored-by: David Markowitz <[email protected]>
aronwk-aaron
approved these changes
May 26, 2024
EmosewaMC
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #746
Splitting AgSpaceStuff into AgSpaceStuff and AgShipShake to match their respective luas.
This is based on their LUA counterparts, rather than the current combination of the two which was previously AgSpaceStuff.
Added AgShipShake.cpp and AgShipShake.h, and incorporated them in CppScripts.cpp.
Tested by compiling, going to venture explorer, and witnessing the intended shake and explosion fx behaviors.
Did not mess with lot 33 lego piece, will do that laters